Skip to content

Conversation

jschanck
Copy link
Collaborator

Resolves #33

@jschanck jschanck requested a review from mozkeeler April 11, 2022 20:41
Copy link
Collaborator

@mozkeeler mozkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good in general. I have a couple of questions/comments.

Copy link
Collaborator

@mozkeeler mozkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I have a few more comments. Also, just wanted to make sure you ran cargo fmt and cargo clippy?

Copy link
Collaborator

@mozkeeler mozkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Copy link
Collaborator

@mozkeeler mozkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@mozkeeler
Copy link
Collaborator

Well, and actually, if you wanted to include tests for invalid layer numbers, that'd be great, but it's not actually important for security - more like a correctness thing, so...

@mozkeeler mozkeeler merged commit 412ba59 into mozilla:main Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Define a new and more performant type of SHA256-based filter

2 participants